SDKS-2669: Add LinkedIn and Microsoft Entra as IDP Providers#539
Open
SteinGabriel wants to merge 1 commit into
Open
SDKS-2669: Add LinkedIn and Microsoft Entra as IDP Providers#539SteinGabriel wants to merge 1 commit into
SteinGabriel wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 24bb850 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
vatsalparikh
requested changes
Jun 25, 2026
vatsalparikh
left a comment
vatsalparikh
left a comment
Contributor
There was a problem hiding this comment.
We are still waiting on testing both icons live in AIC so this is just a code review.
One minor thing on Microsoft icon, everything else looks good!
vatsalparikh
approved these changes
Jun 25, 2026
vatsalparikh
left a comment
vatsalparikh
left a comment
Contributor
There was a problem hiding this comment.
Approving code changes based on Storybook tests. Actual integration and e2e / QA is in progress, I believe, but code changes look good!
feat(select-idp): add LinkedIn and Microsoft theme button classes feat(select-idp): add LinkedIn and Microsoft provider branches chore(select-idp): add LinkedIn and Microsoft entries to mock fixtures feat(select-idp): add LinkedIn and Microsoft Storybook stories test(select-idp): add LinkedIn and Microsoft E2E social redirect tests chore(release): add changeset for LinkedIn and Microsoft IDP support test(select-idp): drop LinkedIn/Microsoft E2E pending AM journeys fix(select-idp): use official Microsoft brand colors for icon fix(select-idp): align Microsoft button bg/border with brand guidelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://pingidentity.atlassian.net/browse/SDKS-2669
Adds LinkedIn and Microsoft Entra ID as out-of-the-box identity providers in the
SelectIdPcallback.Previously the widget only rendered branded buttons for Apple, Facebook, and Google; any other provider fell into a no-render branch. LinkedIn and Microsoft now render branded buttons with brand colors, official logos, and dark mode variants.
Changes
core/components/iconslinkedin-icon.svelte— new LinkedIn "in" logo SVG; acceptsclasses/sizeprops matching the existing icon interface.microsoft-icon.svelte— new 4-color Microsoft squares logo SVG (official sign-in guideline, not the Entra shield); same props interface.core/journey/callbacks/select-idpselect-idp.svelte— added{:else if}branches matchingidp.text.toUpperCase().includes('LINKEDIN')and'MICROSOFT', rendering branded buttons withLinkedinIcon/MicrosoftIconand the new theme classes.No
{:else}fallback added — unknown providers still render nothing.select-idp.mock.ts— addedlinkedin-webandmicrosoft-webentries to all multi-provider step fixtures; addedsingleLinkedInProviderStepandsingleMicrosoftProviderStep. Bumped copyright year.select-idp.stories.js— addedLinkedInandMicrosoftStorybook story variants backed by the single-provider fixtures.themes/defaultjourney.cjs— added.button-linkedin(#0077b5),.button-linkedin_dark,.button-microsoft(#0072c6), and.button-microsoft_dark. Dark mode variants invert to white background with brand-color text, following the Facebook precedent..changesetadd-linkedin-microsoft-idp.md— minor changeset for@forgerock/login-widget.Tests
@testing-library/svelteconfigured (existing limitation).How to test
1. Visual check in Storybook
pnpm storybookCallbacks/SelectIdp→LinkedInandMicrosoftstories.#0077b5button with "in" logo; Microsoft renders blue#0072c6button with 4-color squares logo.2. Build checks
pnpm build:widgetsucceeds.pnpm check:lintpasses.pnpm check:sveltepasses.Verify the fallback path